Quieter top for the review pane
headway:headway/seat-earth-stand, which follows headway:headway/print-wisdom-average. Below are three ways to quiet the band between the card title and the diff. Each one is drawn on the same commit as the screenshot. All three also get two fixes: the peek pill sits on a solid band, and a ba fence draws as a Before | After pair. Pick one. Point 4 (the same point made three times) is a separate question at the end.
Now
A — Trim the recommended set
- Commit subject hidden when it nearly matches the card title. The test: most of the title's words appear in the subject (here 8 of 11). The full subject shows on the sha pill's hover.
- Byline: sha · author · time · source · session. Branch and host:path move into the hover on "local checkout".
- Explainer in the split: no src line, no fact pills, and the title drops from 22px to 17px.
headway: review pane — keys to jump through a commit's code-walk notes
Paren keys through a walk
A commit's code walk is a reading order through its diff: an intro, then one violet note above each hunk it cites. The review pane already had keys for every other list: n/p for cards, ]/[ for files, }/{ for commits. Walking the notes still meant scrolling and hunting for the next violet card. Now ) scrolls the diff so the next walk note is the first row under the pinned file header, and ( goes back. Back from the first note goes to the top, where the intro is. At either end a notice says so ("No later walk note", "No earlier walk note") instead of doing nothing.
Before
) and ( are unbound. Reaching the next walk note means scrolling with j/k/Space until a violet card shows up somewhere in the view.After
) lands the next walk note on the same row every time, just under the pinned file header. ( goes back, and from the first note goes to the top.A code walk is a reading order through its diff, but reaching the next walk note meant scrolling until a violet card showed up. `)` now scrolls the review diff so the next walk note is the first row under the pinned file header, and `(` goes back; back from the first note goes to the top, where the walk's intro is drawn. At either end a notice says so ("No later walk note", "No earlier walk note").
notedeck_ui's patch view gains PatchScroll::StickyNote(NoteStep), landing a note's first row the way File(n) lands a header. It steps only notes that pin (PatchNote::pins: sticky and AboveHunk), so line comments are passed over.
The change adds a generic scroll to the patch widget in crates/notedeck_ui/src/diff/patch_view.rs that lands the next or previous pinning note, then wires Headway's )/( to it. Read the widget first (the variant, the row math, the search, the resolve), then the keymap syntax that makes (/) bindable, then Headway's tool, pane state and notice, and the tests last.
B — Each column owns its header
- No full-width band between the card title and the split. The split starts right under the title rule.
- The right column is the commit. Its subject (always shown, small and strong), a byline that wraps in the column, then the body. The subject sits at the head of its own message, so a near-match doesn't read as a second page title.
- The left column is the explainer. A small "EXPLAINER" label and a 17px title, with no src line and no pills. Branch and host:path go into the hover, as in A.
- Without an explainer (or on a narrow pane), the subject and byline sit over the message at 720px, as they do today.
headway: review pane — keys to jump through a commit's code-walk notes
Explainer
Paren keys through a walk
A commit's code walk is a reading order through its diff: an intro, then one violet note above each hunk it cites. The review pane already had keys for every other list: n/p for cards, ]/[ for files, }/{ for commits. Walking the notes still meant scrolling and hunting for the next violet card. Now ) scrolls the diff so the next walk note is the first row under the pinned file header, and ( goes back. Back from the first note goes to the top, where the intro is. At either end a notice says so ("No later walk note", "No earlier walk note") instead of doing nothing.
Before
) and ( are unbound. Reaching the next walk note means scrolling with j/k/Space until a violet card shows up somewhere in the view.After
) lands the next walk note on the same row every time, just under the pinned file header. ( goes back, and from the first note goes to the top.Commit
headway: review pane — ) and ( step through a commit's code-walk notes
A code walk is a reading order through its diff, but reaching the next walk note meant scrolling until a violet card showed up. `)` now scrolls the review diff so the next walk note is the first row under the pinned file header, and `(` goes back; back from the first note goes to the top, where the walk's intro is drawn.
notedeck_ui's patch view gains PatchScroll::StickyNote(NoteStep), landing a note's first row the way File(n) lands a header.
The change adds a generic scroll to the patch widget in crates/notedeck_ui/src/diff/patch_view.rs that lands the next or previous pinning note, then wires Headway's )/( to it. Read the widget first (the variant, the row math, the search, the resolve), then the keymap syntax that makes (/) bindable, then Headway's tool, pane state and notice, and the tests last.
C — One meta line
- No second title at all: the commit subject and the explainer title are both gone from the split. The card title is the only heading. The subject shows on the sha's hover, and the explainer title in the Explainer tab on narrow panes.
- One muted line under the title holds the sha, author, time and session, then the explainer's facts as plain muted text after a gap. Their numbers stay, but they are no longer pills.
- Branch and host:path go into the hover, as in A.
headway: review pane — keys to jump through a commit's code-walk notes
A commit's code walk is a reading order through its diff: an intro, then one violet note above each hunk it cites. The review pane already had keys for every other list: n/p for cards, ]/[ for files, }/{ for commits. Walking the notes still meant scrolling and hunting for the next violet card. Now ) scrolls the diff so the next walk note is the first row under the pinned file header, and ( goes back. Back from the first note goes to the top, where the intro is. At either end a notice says so ("No later walk note", "No earlier walk note") instead of doing nothing.
Before
) and ( are unbound. Reaching the next walk note means scrolling with j/k/Space until a violet card shows up somewhere in the view.After
) lands the next walk note on the same row every time, just under the pinned file header. ( goes back, and from the first note goes to the top, where the intro is.A code walk is a reading order through its diff, but reaching the next walk note meant scrolling until a violet card showed up. `)` now scrolls the review diff so the next walk note is the first row under the pinned file header, and `(` goes back; back from the first note goes to the top, where the walk's intro is drawn. At either end a notice says so ("No later walk note", "No earlier walk note").
notedeck_ui's patch view gains PatchScroll::StickyNote(NoteStep), landing a note's first row the way File(n) lands a header. It steps only notes that pin (PatchNote::pins: sticky and AboveHunk), so line comments are passed over.
The change adds a generic scroll to the patch widget in crates/notedeck_ui/src/diff/patch_view.rs that lands the next or previous pinning note, then wires Headway's )/( to it. Read the widget first (the variant, the row math, the search, the resolve), then the keymap syntax that makes (/) bindable, then Headway's tool, pane state and notice, and the tests last.
In all three: the peek band and the ba pair
- Peek: the fade now ends in a solid band of panel colour about 44px tall, and the pill sits in it. Code and text fade out above the pill and never run under it. Today the fade is 96px and reaches panel colour only at the very bottom edge, so the pill sits over half-faded text.
- ba fence: the explainer's Before/After block. It splits on ### Title {tone}, and two untoned panes read as alert then moss. It draws as side-by-side panes with Markdown inside, and stacks when the column is narrow. Today it is a raw code block. I'd put this on its own card, since it is a renderer fix rather than a layout change.
Point 4: the same thing said three times
- Leave it. Each one is written for a different reader (the page, the git log, the walk), and the peek already cuts most of it.
- Fold the message's first paragraph in the split when an explainer sits beside it, behind a "…" that opens it (m shows it as written).
- Hide the walk intro while the split is clamped, and show it once E expands it or ( walks back to the top.